Skip to content

Use database for notifications#463

Closed
notAreYouScared wants to merge 2 commits intomainfrom
notifications
Closed

Use database for notifications#463
notAreYouScared wants to merge 2 commits intomainfrom
notifications

Conversation

@notAreYouScared
Copy link
Copy Markdown
Member

Adds a notification bell on top bar and saves notification history.

For future use in the front end, ex. Server crashes.

Adds a notification bell on top bar and  saves notification history. For use in the front end, ex. Server crashes.
@rmartinoscar
Copy link
Copy Markdown
Member

Hey i believe we can use $panel->databaseNotifications() in AdminPanelProvider.php with Filament 3 to avoid repetitiveness

@notAreYouScared
Copy link
Copy Markdown
Member Author

Hey i believe we can use $panel->databaseNotifications() in AdminPanelProvider.php with Filament 3 to avoid repetitiveness

We already use that. That's how you get the notification panel to appear at the top

Copy link
Copy Markdown
Member

@lancepioch lancepioch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This basically duplicates the activity log. It should be consolidated.

Copy link
Copy Markdown
Member

@Boy132 Boy132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Lance. We should only send database notifications for "important" stuff. Sending both notifications for a simple success or error notification seems unnecessary.

@notAreYouScared
Copy link
Copy Markdown
Member Author

notAreYouScared commented Jul 8, 2024

This basically duplicates the activity log. It should be consolidated.

Are you referring to the client area activity log? This does not. These are notifications, Not a log.

I still plan to keep activity logs per server.

Also, there is no log for the admin side.

@github-actions github-actions Bot locked and limited conversation to collaborators Aug 18, 2024
@Boy132 Boy132 deleted the notifications branch December 12, 2024 07:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants