remove 'guest' middleware to enable oauth account linking#544
Closed
EkiciLP wants to merge 1 commit intopelican-dev:mainfrom
EkiciLP:fix/oauth-account-linking
Closed
remove 'guest' middleware to enable oauth account linking#544EkiciLP wants to merge 1 commit intopelican-dev:mainfrom EkiciLP:fix/oauth-account-linking
EkiciLP wants to merge 1 commit intopelican-dev:mainfrom
EkiciLP:fix/oauth-account-linking
Conversation
Member
|
The redirect endpoint is not used for linking but for logging in. For authenticated users it doesn't make sense to login again with oauth. |
Author
|
Yes but the link endpoint currently just redirects to the oauth/redirect endpoint which would fail. |
Member
|
It doesn't. The link endpoint redirects to the oauth provider page which then redirects back to the callback endpoint. |
Author
|
Ah sorry i swapped the redirect and callback endpoint in my head. The objective of this commit was for users to link their account without the frontend being done as they can't send get requests with a body using their browser. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
guestmiddleware did not allow for authenticated users to call the /auth/oauth/redirect endpoint resulting in not being able to link an oauth account to yours.