Skip to content

Default to 8443 if https#702

Closed
rmartinoscar wants to merge 1 commit intopelican-dev:mainfrom
rmartinoscar:fix/default-8443-https
Closed

Default to 8443 if https#702
rmartinoscar wants to merge 1 commit intopelican-dev:mainfrom
rmartinoscar:fix/default-8443-https

Conversation

@rmartinoscar
Copy link
Copy Markdown
Member

No description provided.

@rmartinoscar rmartinoscar self-assigned this Nov 7, 2024
@rmartinoscar rmartinoscar requested review from Boy132 and notAreYouScared and removed request for notAreYouScared November 7, 2024 04:54
@Boy132
Copy link
Copy Markdown
Member

Boy132 commented Nov 7, 2024

Why? There is no reason to always default to 8443 if using https.

@rmartinoscar
Copy link
Copy Markdown
Member Author

Feels wrong to server https over a http port; Maybe i should set it to 4443 instead of 8443 even 🤔

@Boy132
Copy link
Copy Markdown
Member

Boy132 commented Nov 7, 2024

8080 is not a http port per se. Just with cloudflare.

@rmartinoscar
Copy link
Copy Markdown
Member Author

8080 is not a http port per se. Just with cloudflare.

So you would serve https over 81 without thinking about it ?

@Boy132
Copy link
Copy Markdown
Member

Boy132 commented Nov 7, 2024

8080 is not a http port per se. Just with cloudflare.

So you would serve https over 81 without thinking about it ?

Wings doesn't care about the port. 81 would work with https, 444 with http.
As long as there is no software limitation it makes no sense to have two default ports. That just adds unnecessary complexity.

@rmartinoscar rmartinoscar deleted the fix/default-8443-https branch November 7, 2024 22:21
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants