Allow Database Hosts to have multiple Nodes#724
Closed
alexevladgabriel wants to merge 12 commits intopelican-dev:mainfrom
Closed
Allow Database Hosts to have multiple Nodes#724alexevladgabriel wants to merge 12 commits intopelican-dev:mainfrom
alexevladgabriel wants to merge 12 commits intopelican-dev:mainfrom
Conversation
rmartinoscar
requested changes
Nov 22, 2024
Member
rmartinoscar
left a comment
rmartinoscar
left a comment
There was a problem hiding this comment.
MySql/Mariadb needs explicit type
| public function up(): void | ||
| { | ||
| Schema::create('database_host_node', function (Blueprint $table) { | ||
| $table->id(); |
Member
There was a problem hiding this comment.
Suggested change
| $table->id(); | |
| $table->id(); | |
| $table->unsignedInteger('node_id'); |
| public function down(): void | ||
| { | ||
| Schema::table('database_hosts', function (Blueprint $table) { | ||
| $table->foreignId('node_id')->nullable()->references('id')->on('nodes'); |
Member
There was a problem hiding this comment.
Suggested change
| $table->foreignId('node_id')->nullable()->references('id')->on('nodes'); | |
| $table->unsignedInteger('node_id')->nullable(); | |
| $table->foreignId('node_id')->references('id')->on('nodes'); |
rmartinoscar
changed the title
Member
|
Closed in favor of #767 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #133