Fix docker build after vite update#883
Closed
Boy132 wants to merge 3 commits intopelican-dev:mainfrom
Boy132:fix/docker-build
Closed
Fix docker build after vite update#883Boy132 wants to merge 3 commits intopelican-dev:mainfrom Boy132:fix/docker-build
Boy132 wants to merge 3 commits intopelican-dev:mainfrom
Boy132:fix/docker-build
Conversation
rmartinoscar
approved these changes
Jan 7, 2025
rmartinoscar
requested changes
Jan 7, 2025
Member
There was a problem hiding this comment.
Crap i didn't meant to review yarn won't be able to run without composer deps already installed because of
Line 1 in 7449b82
rmartinoscar
requested changes
Jan 7, 2025
|
|
||
| WORKDIR /build | ||
|
|
||
| RUN yarn run build |
Member
There was a problem hiding this comment.
yarn isn't in the php image
Member
Author
|
I let someone else handle this, I don't know docker images too well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.