Skip to content

First removal of unused variables#96

Closed
notAreYouScared wants to merge 1 commit into3.xfrom
issue/fix-2
Closed

First removal of unused variables#96
notAreYouScared wants to merge 1 commit into3.xfrom
issue/fix-2

Conversation

@notAreYouScared
Copy link
Copy Markdown
Member

Working on Issue #2, Removing unused variables.

@Boy132
Copy link
Copy Markdown
Member

Boy132 commented Apr 17, 2024

Aren't some of the request variables you removed needed for things like permission checks? Like GetEggRequest for example?

@notAreYouScared
Copy link
Copy Markdown
Member Author

Aren't some of the request variables you removed needed for things like permission checks? Like GetEggRequest for example?

image

Where is the variable $request used in these functions...

    public function index(GetEggsRequest $request): array
    {
        return $this->fractal->collection(Egg::all())
            ->transformWith($this->getTransformer(EggTransformer::class))
            ->toArray();
    }

    /**
     * Return a single egg that exists
     */
    public function view(GetEggRequest $request, Egg $egg): array
    {
        return $this->fractal->item($egg)
            ->transformWith($this->getTransformer(EggTransformer::class))
            ->toArray();
    }
}

@Boy132
Copy link
Copy Markdown
Member

Boy132 commented Apr 17, 2024

@notAreYouScared notAreYouScared deleted the issue/fix-2 branch April 18, 2024 01:01
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants