Address code review feedback: accessibility, z-index fix, and cleanup #1050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Copilot
AI
changed the title
[WIP] Change logo redirect behaviour to stay under /widget and introduce useReducedMotion
Address review feedback in separate PR per maintainer request
Jan 30, 2026
…ect animation durations, and cleanup unused vars Co-authored-by: ebma <6690623+ebma@users.noreply.github.com>
Copilot
AI
changed the title
Address review feedback in separate PR per maintainer request
Address code review feedback: accessibility, z-index fix, and cleanup
Jan 30, 2026
Sharqiewicz
reviewed
Jan 30, 2026
|
|
||
| export const Navbar = () => ( | ||
| <header className="relative z-60"> | ||
| <header className="relative z-50"> |
Member
There was a problem hiding this comment.
z-60 is a valid value and we should leave it
Sharqiewicz
reviewed
Jan 30, 2026
| export const durations = { | ||
| fast: 0.15, // 100ms - micro-interactions (hover states) | ||
| micro: 0.1, // 150ms - tooltips, dropdowns | ||
| fast: 0.1, // 100ms - micro-interactions (hover states) |
Member
There was a problem hiding this comment.
there is no need to change it
ebma
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements automated review suggestions for improved accessibility and code quality.
Changes
Accessibility
motion-reduce:transition-noneto CSS grid transitions inSelectionDropdownMotion,CollapsibleCard, andAccordioncomponents to respect user motion preferences at the CSS levelTailwind Compliance
z-60toz-50in Navbar (z-60 is not a standard Tailwind utility)Code Quality
constants/animations.ts(fast: 0.1→ "100ms",micro: 0.15→ "150ms")setOpenItemsvariable inAccordion.stories.tsxSelectionDropdownMotionby removing always-trueisOpencheck in delay calculationExample
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.