Skip to content

[READY] Update Individuals Hero Section#1100

Merged
Sharqiewicz merged 9 commits intostagingfrom
feat/introduce-cobe
Apr 2, 2026
Merged

[READY] Update Individuals Hero Section#1100
Sharqiewicz merged 9 commits intostagingfrom
feat/introduce-cobe

Conversation

@Sharqiewicz
Copy link
Copy Markdown
Member

No description provided.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 31, 2026

Deploy Preview for vortex-sandbox ready!

Name Link
🔨 Latest commit 128d6b6
🔍 Latest deploy log https://app.netlify.com/projects/vortex-sandbox/deploys/69cd4ab9ee538800080530ec
😎 Deploy Preview https://deploy-preview-1100--vortex-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 31, 2026

Deploy Preview for vortexfi ready!

Name Link
🔨 Latest commit 128d6b6
🔍 Latest deploy log https://app.netlify.com/projects/vortexfi/deploys/69cd4ab906e9230008a4ebf7
😎 Deploy Preview https://deploy-preview-1100--vortexfi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Sharqiewicz Sharqiewicz changed the title Update Individuals Hero Section [IN PROGRESS] Update Individuals Hero Section Mar 31, 2026
@Sharqiewicz Sharqiewicz changed the title [IN PROGRESS] Update Individuals Hero Section [READY] Update Individuals Hero Section Mar 31, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Individuals landing page hero visuals and CTA copy by replacing the static widget preview with a new interactive globe component (powered by cobe), plus some small navigation CTA styling/text adjustments.

Changes:

  • Add cobe dependency to support a new globe visualization.
  • Replace Individuals Hero widget preview images with a new <Globe /> component.
  • Update Desktop navbar CTA label and adjust its border-radius styling.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
package.json Adds cobe dependency (currently only at workspace root).
bun.lock Locks cobe@2.0.1.
apps/frontend/src/sections/individuals/Hero/index.tsx Swaps widget preview imagery for the new globe and adjusts hero padding classes.
apps/frontend/src/components/Navbar/DesktopNavbar.tsx Updates CTA text and adjusts Tailwind classes on the button.
apps/frontend/src/components/Globe/index.tsx Introduces the new interactive globe + overlay markers implementation.
contracts/relayer/typechain-types/contracts/MockERC20Permit.ts TypeChain generated type tweak for an event output type.
contracts/relayer/typechain-types/@openzeppelin/contracts/utils/cryptography/EIP712.ts TypeChain generated type tweak for an event output type.
contracts/relayer/typechain-types/@openzeppelin/contracts/token/ERC20/extensions/ERC20Permit.ts TypeChain generated type tweak for an event output type.
contracts/relayer/typechain-types/@openzeppelin/contracts/interfaces/IERC5267.ts TypeChain generated type tweak for an event output type.
Comments suppressed due to low confidence (1)

package.json:52

  • cobe is imported by the frontend (apps/frontend/src/components/Globe/index.tsx) but is only added to the root package.json. To keep workspace dependencies accurate and avoid install/build issues when operating within the apps/frontend workspace (or with stricter tooling), add cobe to apps/frontend/package.json as well (likely using the repo’s catalog: pattern).
  "dependencies": {
    "big.js": "^7.0.1",
    "cobe": "^2.0.1",
    "husky": "^9.1.7",
    "lint-staged": "^16.1.0",
    "numora-react": "^3.0.3"
  },

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

<section
aria-label={t("pages.main.hero.title")}
className="relative overflow-hidden bg-[radial-gradient(at_74%_98%,theme(colors.blue.900),theme(colors.blue.950),theme(colors.blue.950))] py-16 lg:py-32"
className="relative overflow-hidden bg-[radial-gradient(at_74%_98%,theme(colors.blue.900),theme(colors.blue.950),theme(colors.blue.950))] py-16 lg:py-42"
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg:py-42 is not a standard Tailwind spacing utility (and this repo is using Tailwind v4 CSS-first config without a custom spacing scale). This class will be ignored, so the large-screen padding likely won’t change as intended. Use a valid spacing token (e.g., lg:py-32/lg:py-40) or an arbitrary value (e.g., lg:py-[10.5rem]) if you need an exact size.

Suggested change
className="relative overflow-hidden bg-[radial-gradient(at_74%_98%,theme(colors.blue.900),theme(colors.blue.950),theme(colors.blue.950))] py-16 lg:py-42"
className="relative overflow-hidden bg-[radial-gradient(at_74%_98%,theme(colors.blue.900),theme(colors.blue.950),theme(colors.blue.950))] py-16 lg:py-40"

Copilot uses AI. Check for mistakes.
<div className="flex items-center">
<Link className="btn btn-vortex-secondary rounded-3xl" to="/{-$locale}/widget">
Buy & Sell
<Link className="btn btn-vortex-secondary rounded-3xl!" to="/{-$locale}/widget">
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rounded-3xl! is not valid Tailwind syntax for the important modifier. Tailwind uses a leading ! (e.g., !rounded-3xl) rather than a trailing one, so this won’t apply and may leave the button with unintended styling.

Suggested change
<Link className="btn btn-vortex-secondary rounded-3xl!" to="/{-$locale}/widget">
<Link className="btn btn-vortex-secondary !rounded-3xl" to="/{-$locale}/widget">

Copilot uses AI. Check for mistakes.
Comment on lines +152 to +155
const mq = window.matchMedia("(min-width: 1024px), (min-width: 640px)");
const handler = () => setSize(getGlobeSize());
mq.addEventListener("change", handler);
return () => mq.removeEventListener("change", handler);
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

window.matchMedia("(min-width: 1024px), (min-width: 640px)") is effectively just (min-width: 640px) (since 1024px implies 640px). As a result, the change event won’t fire when crossing the 1024px breakpoint, so the globe size won’t update from md to lg. Use separate media queries/listeners (or a resize observer) so both breakpoint crossings trigger a recalculation.

Suggested change
const mq = window.matchMedia("(min-width: 1024px), (min-width: 640px)");
const handler = () => setSize(getGlobeSize());
mq.addEventListener("change", handler);
return () => mq.removeEventListener("change", handler);
const mqSm = window.matchMedia("(min-width: 640px)");
const mqLg = window.matchMedia("(min-width: 1024px)");
const handler = () => setSize(getGlobeSize());
mqSm.addEventListener("change", handler);
mqLg.addEventListener("change", handler);
return () => {
mqSm.removeEventListener("change", handler);
mqLg.removeEventListener("change", handler);
};

Copilot uses AI. Check for mistakes.
Comment on lines +178 to +182
<div
className={cn("relative cursor-grab select-none active:cursor-grabbing lg:absolute", className)}
style={{ height: size, touchAction: "manipulation", width: size }}
{...dragHandlers}
>
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dragHandlers includes isDraggingRef, and spreading {...dragHandlers} onto a DOM <div> will pass isDraggingRef as an unknown attribute. This can produce React warnings and may end up in the DOM. Only spread the pointer event handlers and keep isDraggingRef separate (e.g., destructure it out before spreading).

Copilot uses AI. Check for mistakes.
@ebma ebma self-requested a review April 1, 2026 08:59
Copy link
Copy Markdown
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

Let's address the comments generated by the copilot review and merge afterward @Sharqiewicz.

@Sharqiewicz
Copy link
Copy Markdown
Member Author

@ebma ready ✅

@Sharqiewicz Sharqiewicz merged commit 4971165 into staging Apr 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants