Implement isExternal handling for Alfredpay Fiat Accounts#1129
Merged
Conversation
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Alfredpay fiat account creation to support marking a bank account as external (not owned by the user) and wires that flag through the frontend form and API.
Changes:
- Adds
isExternal?: booleanto the shared Alfredpay add-fiat-account request type. - Updates the frontend fiat account registration form to ask “Who does this account belong to?” and sends
isExternalaccordingly. - Tweaks the shared Select UI component styling/behavior (sizes, motion-safe animations, icon
aria-hidden).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/shared/src/endpoints/alfredpay.endpoints.ts | Extends AlfredpayAddFiatAccountRequest with optional isExternal. |
| apps/api/src/api/controllers/alfredpay.controller.ts | Reads isExternal from request body and forwards it to Alfredpay fiat account creation payload. |
| apps/frontend/src/constants/fiatAccountForms.ts | Adds an “isOwnAccount” select field (default “own”) across fiat account forms. |
| apps/frontend/src/pages/alfredpay/FiatAccountRegistration/RegisterFiatAccountScreen.tsx | Provides form defaultValues and maps isOwnAccount → isExternal when submitting. |
| apps/frontend/src/translations/en.json | Adds i18n strings for the new “account ownership” field/options. |
| apps/frontend/src/translations/pt.json | Adds i18n strings for the new “account ownership” field/options. |
| apps/frontend/src/components/ui/select.tsx | Updates Select trigger sizing, motion-safe classes, z-index, colors, and icon accessibility. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sharqiewicz
changed the title
…chain/vortex into alfredpay-quote-expiration-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.