Skip to content

Update Mexico and Colombia KYC Forms#1131

Open
Sharqiewicz wants to merge 3 commits intostagingfrom
feat/alfredpay-isExternal-us-checking
Open

Update Mexico and Colombia KYC Forms#1131
Sharqiewicz wants to merge 3 commits intostagingfrom
feat/alfredpay-isExternal-us-checking

Conversation

@Sharqiewicz
Copy link
Copy Markdown
Member

No description provided.

@Sharqiewicz Sharqiewicz requested review from ebma and gianfra-t April 30, 2026 13:14
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 30, 2026

Deploy Preview for vortex-sandbox ready!

Name Link
🔨 Latest commit d4a0f65
🔍 Latest deploy log https://app.netlify.com/projects/vortex-sandbox/deploys/69f3727449b6a000081e8654
😎 Deploy Preview https://deploy-preview-1131--vortex-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 30, 2026

Deploy Preview for vortexfi ready!

Name Link
🔨 Latest commit d4a0f65
🔍 Latest deploy log https://app.netlify.com/projects/vortexfi/deploys/69f372745de310000718913f
😎 Deploy Preview https://deploy-preview-1131--vortexfi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Alfredpay KYC UX/validation for Mexico and Colombia, and flips MXN/COP to “enabled” in the shared supported-fiat list (which affects both frontend availability and API quote validation).

Changes:

  • Enabled MXN and COP in SUPPORTED_FIAT_CURRENCIES.
  • Simplified Mexico KYC form by removing the document type field.
  • Updated Colombia KYC form: stricter DNI/phone validation, switched document type input to the shared Select, and adjusted phone input UI/normalization.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
packages/shared/src/services/alfredpay/types.ts Minor KYC request typing/comment tweak (no behavioral change).
packages/shared/src/endpoints/supported-fiat-currencies.endpoints.ts Enables MXN/COP for shared “supported fiat” gating.
apps/frontend/src/components/Alfredpay/MxnKycFormScreen.tsx Removes MX document type selection from the form.
apps/frontend/src/components/Alfredpay/ColKycFormScreen.tsx Updates CO KYC validation and inputs (Select + phone input changes).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 6 to 7
import type { MxnKycFormData } from "../../machines/alfredpayKyc.machine";
import { MenuButtons } from "../MenuButtons";
placeholder="573000000000"
type="tel"
{...register("phoneNumber", {
setValueAs: (v: string) => (v ? `+${v.replace(/^\+/, "")}` : v)
@ebma
Copy link
Copy Markdown
Member

ebma commented Apr 30, 2026

@copilot apply changes based on the comments in this thread

@ebma
Copy link
Copy Markdown
Member

ebma commented Apr 30, 2026

@copilot apply changes based on the comments in #1131 (review)

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 30, 2026

@copilot apply changes based on the comments in #1131 (review)

Done in d4a0f65:

  1. Mexico-specific type coupling (ColKycFormScreen.tsx:6-7): Removed the MxnKycFormData import and changed the onSubmit prop type to use the Colombia-specific ColKycFormValues (derived from the local Zod schema via z.infer<typeof schema>).

  2. Phone normalization (ColKycFormScreen.tsx:157): Updated setValueAs to strip all non-digit characters after removing any leading "+" — +${v.replace(/^\+/, "").replace(/\D/g, "")} — so pasted inputs like +57 300 000 0000 correctly normalize to +573000000000 before regex validation.

Copilot finished work on behalf of ebma April 30, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants