Offramp prototype - Phase 2#18
Conversation
ebma
left a comment
There was a problem hiding this comment.
I think this is already in a very good state, nice job @gianfra-t 👌
Would be nice to test the whole flow with the proper secrets or in a test environment but we have to clarify this on Slack.
Can you please run yarn lint and fix some of the errors? I'm fine if we ignore some of the warnings but some useEffect hooks are missing dependencies which can lead to bugs and eslint will point this out to you.
|
@ebma regarding the linting issues, there are 2 that I decided to deactivate the warning for: Here it was complaining about some variables not being listed as dependency of the hook. In this particular case I think we can either ignore it or refactor how the processes are started entirely, since the intention of this hook is to only trigger upon change of the And here we have defined an |
|
I fixed those two issues as well. It's risky to ignore the I think this solves #17. We should wait for someone to test the whole flow. And we should also not merge this branch for now and keep the changes on the extra branch. |
|
@ebma I agree with the hook issue, but wouldn't the new refactor of the promise return as soon as the transaction is signed, and not wait for the actual event emitted? Previously we where passing the |
Ohh yes, thanks for double-checking that! I changed it again, please have another look 😅 |
…n/pendulum-pay into spacewalk-mykobo-prototype
|
Same comment here, please change this PR to not merge into |
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 5b4a4cc |
by changing the used polyfills
by also defining the target to `esnext`
9aeb73c to
baa28f4
Compare
|
@gianfra-t @ebma can you please add these lines to |
|
@gianfra-t seems like you didn't reset the branch to the upstream version and now the changes that I moved to |
|
Oh sorry! Let me do that. |
5b4a4cc to
4042bc7
Compare
|
@gianfra-t Since the testing is completed now, I think we can finally merge this PR to the staging branch and focus only on phase 3 again. |
|
Great, I will close this. Do you know if the changes are deployed automatically on Netlify or we need to trigger manually? |
|
It was automatically deployed to https://offramp-prototype-staging--pendulum-pay.netlify.app/ |
Possible improvements
Although this is a prototype, there are some checks and improvements that could be improved on a more refined system.
This check is quite simple to add and would save the user time and confusion.
We could improve this by using cookies such that upon reloading of the page, an existing operation could resume. Careful consideration must be done into what secrets are stored on the local storage.
Closes #19