[Draft] Spacewalk mykobo prototype phase 1#21
Merged
Conversation
…n/pendulum-pay into spacewalk-mykobo-prototype
Contributor
TorstenStueber
left a comment
There was a problem hiding this comment.
Thanks, nicely done.
Please change this PR so that it does not merge into main, but into some special branch that we use for the prototype, as specified in the original ticket (there I proposed offramp-prototype).
This is just a prototype, so none of the following statements really matter for this code base. However, I want to already leave a few general comments as a reference for a future actual production implementation.
- To be consistent with our style and to adopt common TypeScript conventions, don't prefix Interfaces with "I", just use the normal name.
- I think we should optimize for colocation, particularly when it comes to CSS and therefore don't put the CSS code in an extra file; in my opinion the CSS framework that maximizes colocation is Tailwind.
- Most components will then only be a single file -> in this case I think we should not put them into an index.ts file inside a folder but keep it flat. At least when editing it is much easier to find a file just looking at the name on the tab.
- This PR replaces
bn.jswithbig.js. Polkadot.js already comes withbn.js, no need to add yet another big number library (parsing numbers with decimals is also straightforward without any libraries). We should strive to keep our npm dependencies as minimal as possible to lower the attack surface and keep the build small.
| const server = new Horizon.Server(HORIZON_URL); | ||
| const keypair = Keypair.fromSecret(secret); | ||
|
|
||
| //loading the account should be enough check if the account exists |
Member
|
I'm merging this already in order to be able to establish a good structure for branches and deployments. Let's address the comments in the next iterations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17.
This PR contains the first steps of the prototype, with the requirements for Phase 1.