Skip to content

Add check for BRL ramping amount#597

Merged
ebma merged 3 commits into
stagingfrom
add-check-for-brl-ramping-amount
Apr 24, 2025
Merged

Add check for BRL ramping amount#597
ebma merged 3 commits into
stagingfrom
add-check-for-brl-ramping-amount

Conversation

@ebma
Copy link
Copy Markdown
Member

@ebma ebma commented Apr 24, 2025

  • Adds an endpoint to check the remaining limit of a BRLA subaccount. The endpoint already subtracts the used limit from the total to calculate the remaining.
  • Add a 'preRampCheck' that currently only checks if the amount that the user wants to ramp is within the allowed limits. For simplicity, the check is only executed once the user clicks on the confirm. It's not triggered when the user updates the value in the form. I decided to go this way as we will very soon change the logic to simply change the behaviour of the submit button if the user exceeds the remaining limit instead of showing an error. Thus, going for a better UX at the moment would be wasted effort.

Supersedes #533 and closes #518.

@ebma ebma requested a review from gianfra-t April 24, 2025 17:04
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 24, 2025

Deploy Preview for pendulum-pay canceled.

Name Link
🔨 Latest commit ff4e96f
🔍 Latest deploy log https://app.netlify.com/sites/pendulum-pay/deploys/680a7cf0e9e88800089dec17

@ebma ebma mentioned this pull request Apr 24, 2025
3 tasks
Copy link
Copy Markdown
Contributor

@gianfra-t gianfra-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ebma ebma merged commit 15498d6 into staging Apr 24, 2025
5 checks passed
@ebma ebma deleted the add-check-for-brl-ramping-amount branch April 24, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add check for BRL ramping amount

2 participants