Add LanguageSelector in the navbar#646
Merged
Merged
Conversation
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new language selector to the navbar, enabling users to switch between English and Portuguese and have the URL update accordingly.
- Imports and renders
LanguageSelectoralongside existing controls in the navbar. - Introduces a
LanguageSelectorcomponent with dropdown UI, click-outside hook, and path-updating logic. - Adds helper functions (
useClickOutside,updatePathWithLanguage) and flag assets.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/src/components/Navbar/index.tsx | Imported and rendered LanguageSelector with disabled prop |
| frontend/src/components/LanguageSelector/index.tsx | Added new LanguageSelector component and associated helpers |
Comments suppressed due to low confidence (2)
frontend/src/components/Navbar/index.tsx:31
- [nitpick] The prop name
networkSelectorDisabledis specific to network selection. Consider renaming it to a more generic name (e.g.,selectorDisabled) or introducing a dedicatedlanguageSelectorDisabledprop to clarify its purpose.
<LanguageSelector disabled={networkSelectorDisabled} />
frontend/src/components/LanguageSelector/index.tsx:111
- There are currently no tests covering
LanguageSelectorbehavior (open/close, language switching, URL update). Consider adding unit or integration tests for these scenarios.
export const LanguageSelector = ({ disabled }: { disabled?: boolean }) => {
| } | ||
|
|
||
| const LanguageButton = ({ selectedLanguage, isOpen, onClick, disabled }: LanguageButtonProps) => ( | ||
| <motion.button |
There was a problem hiding this comment.
Consider adding ARIA attributes (e.g., aria-haspopup='menu', aria-expanded) and keyboard event handling (Enter/Space to toggle, arrow keys to navigate) to improve the dropdown’s accessibility.
| }, [callback, ref]); | ||
| } | ||
|
|
||
| // Helper function to update path with language |
There was a problem hiding this comment.
Add a JSDoc comment explaining how updatePathWithLanguage detects existing language segments and replaces or prepends them, to aid future maintainers in understanding the logic.
Suggested change
| // Helper function to update path with language | |
| /** | |
| * Updates the given path to include the specified language segment. | |
| * | |
| * This function checks if the path already contains a language segment | |
| * (e.g., "/en" or "/pt-br"). If a language segment is found, it replaces | |
| * it with the new language. If no language segment is found, it prepends | |
| * the new language segment to the path. | |
| * | |
| * @param {string} path - The URL path to update. | |
| * @param {Language} language - The language to include in the path. | |
| * @returns {string} - The updated path with the specified language segment. | |
| */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.