Fix quote validation and improve error handling for input amount#742
Merged
Conversation
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to improve error handling and localization in the ramp validation and quote retrieval processes. Key updates include replacing hardcoded error messages with translatable keys, adding new translation entries, and refining input validation logic.
Error Handling and Localization Improvements:
useRampValidationto return localized error messages by using thetfunction for translation (apps/frontend/src/hooks/ramp/useRampValidation.ts).errorfield inQuoteStateto store either an error message or a translation key, enabling better localization (apps/frontend/src/stores/ramp/useQuoteStore.ts).useQuoteStore(apps/frontend/src/stores/ramp/useQuoteStore.ts). [1] [2]Translation Additions:
fetchingQuoteandinvalidInputAmountin English (apps/frontend/src/translations/en.json). [1] [2]fetchingQuoteandinvalidInputAmountin Portuguese (apps/frontend/src/translations/pt.json). [1] [2]