Merged
Conversation
mivade
approved these changes
Mar 8, 2018
| return events | ||
|
|
||
|
|
||
| def extract_relevant_sessions(experiment, sessions): |
Contributor
There was a problem hiding this comment.
I'm not sure that I like the naming of this function, but since you're documenting exactly what it means it's not a showstopper.
| used_pair_mask, excluded_pairs, | ||
| final_pairs, pairs_metadata_table, | ||
| all_events, **kwargs): | ||
| all_events, **kwargs): |
Contributor
There was a problem hiding this comment.
Accidental extra whitespace here.
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
==========================================
- Coverage 55.95% 55.22% -0.73%
==========================================
Files 33 33
Lines 3208 3319 +111
==========================================
+ Hits 1795 1833 +38
- Misses 1413 1486 +73
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated how the existing sessions parameter is used to allow for explicitly passed sessions to implicitly exclude sessions. catFR sessions must be offset by 100 and PAL must be offset by 200. FR and PS start at 0