Let consumers of the gem handle pagination

[emilesilvis]

Currently the gem paginates for you, often leading to the rate limit being hit and difficult-to-handle exceptions being thrown. While I think it's good to introduce an exception for when the rate limit is hit, I also think that pagination should be left up to the consumer of the gem (as mentioned here).

That way, we don't end up with being half-way through iterating through a collection and then getting the RateLimitError thrown. Plus, then it's a more faithful mirroring of the actual RESTful API.

Thoughts?

[phoet]

sure, this can become anoying quickly.

i think a simple solution could be allow an optional block on the method that yields the chunks.

by asking the client about the current rate-limit additional measures could be taken, i guess that only sleeping is likely to help?

[emilesilvis]

Yeah, yielding the block does indeed seem like a good solution. Yes, indeed what I do now - I wrap calls to the gem in a method that sleeps when the rate limit is low. Op ma 9 dec. 2019 om 08:56 schreef Peter Schröder <notifications@github.com>

…

sure, this can become anoying quickly. i think a simple solution could be allow an optional block on the method that yields the chunks. by asking the client about the current rate-limit <https://github.com/penseo/webflow-ruby/blob/master/lib/webflow/client.rb#L131-L134> additional measures could be taken, i guess that only sleeping is likely to help? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#9?email_source=notifications&email_token=AAEICGQ72KTANQKNJOT6BDTQXX2ZRA5CNFSM4JYEB5XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGIGHVI#issuecomment-563110869>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEICGWPYN5JNS4X3THZ7ZDQXX2ZRANCNFSM4JYEB5XA> .

[phoet]

closed by 40b981e

@emilesilvis if you like, you could try version 1.1.0 that has just been pushed

[emilesilvis]

Awesome, thanks @phoet ❤️