-
Notifications
You must be signed in to change notification settings - Fork 18
Pagination & larger collection sizes #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,9 +48,37 @@ def collection(collection_id) | |
| get("/collections/#{collection_id}") | ||
| end | ||
|
|
||
|
|
||
| # https://developers.webflow.com/?javascript#get-all-items-for-a-collection | ||
| # returns json object with data to help paginate collection | ||
| # | ||
| # { | ||
| # items: your list of items returned, | ||
| # count: number of items returned, | ||
| # limit: the limit specified in the request (default: 100), | ||
| # offset: the offset specified for pagination (default: 0), | ||
| # total: total # of items in the collection | ||
| # } | ||
| # | ||
| # page starts at 1 | ||
| def paginate_items(collection_id, per_page: 100, page: 1) | ||
| get("/collections/#{collection_id}/items", params: { limit: per_page, offset: per_page * (page - 1) }) | ||
| end | ||
|
|
||
|
|
||
| def items(collection_id, limit: 100) | ||
| json = get("/collections/#{collection_id}/items", params: {limit: limit}) | ||
| json['items'] | ||
| fetched_items = [] | ||
| num_pages = (limit.to_f / 100.0).ceil | ||
| per_page = limit > 100 ? 100 : limit | ||
|
|
||
| num_pages.times do |i| | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i like this pattern to avoid a while loop 👍 |
||
| resp = paginate_items(collection_id, per_page: (limit > 100 ? 100 : limit), page: i+1) | ||
| fetched_items += resp['items'] | ||
| limit -= resp['count'] | ||
| break if limit <= 0 || resp['total'] <= fetched_items.length | ||
| end | ||
|
|
||
| fetched_items | ||
| end | ||
|
|
||
| def item(collection_id, item_id) | ||
|
|
||
185 changes: 184 additions & 1 deletion
185
test/fixtures/cassettes/test_it_fetches_a_single_item.yml
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you know
number.fdiv?