Add configuration support#6
Merged
phoet merged 3 commits intopenseo:masterfrom Aug 30, 2019
mateuscruz:add-config-module
Merged
Add configuration support#6phoet merged 3 commits intopenseo:masterfrom mateuscruz:add-config-module
phoet merged 3 commits intopenseo:masterfrom
mateuscruz:add-config-module
Conversation
This is to avoid repeating the API token every time we need a client.
phoet
suggested changes
Aug 30, 2019
Contributor
phoet
left a comment
phoet
left a comment
There was a problem hiding this comment.
Thx for the PR. This looks mostly good to me. Could you add a note to the changelog?
| @token = token | ||
| def initialize(token = nil) | ||
| @token = Webflow.config.api_token || token | ||
| @rate_limit = {} |
Contributor
There was a problem hiding this comment.
The token passed should take precedence over the configuration option.
Contributor
Author
|
@phoet thanks for the quick review! I've made the requested changes. |
phoet
approved these changes
Aug 30, 2019
Contributor
|
@mateuscruz i released a new version for this https://rubygems.org/gems/webflow-ruby/versions/0.7.0 |
Contributor
Author
|
Awesome! Thanks a lot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to avoid repeating the API token every time we need a client.
Usage would look like this:
From this point on, any new instance of
Webflow::Clientwill have'your_api_token'as default.