Skip to content

feat: allow for live item updates (false by default)#8

Merged
phoet merged 2 commits intopenseo:masterfrom
emilesilvis:feat/live-item-updates
Dec 8, 2019
Merged

feat: allow for live item updates (false by default)#8
phoet merged 2 commits intopenseo:masterfrom
emilesilvis:feat/live-item-updates

Conversation

@emilesilvis
Copy link
Copy Markdown
Contributor

@phoet
Copy link
Copy Markdown
Contributor

phoet commented Sep 1, 2019

Does this also work while passing the live parameter as data to the put call? Would think of that of the cleaner solution.

@emilesilvis
Copy link
Copy Markdown
Contributor Author

I'd have to investigate @phoet. The query parameter is the way it's documented in their API docs.

@phoet
Copy link
Copy Markdown
Contributor

phoet commented Sep 3, 2019

yeah, i saw that and i found it a bit weird... anyhow! thx for the contribution, some things:

a) please make it a named parameter
b) add it to all methods that allow the new live collection item, that is post, put, patch
c) let the request method handle it, otherwise it will break parameterized urls

@phoet
Copy link
Copy Markdown
Contributor

phoet commented Dec 4, 2019

@emilesilvis do you still want to get this merged?

@emilesilvis
Copy link
Copy Markdown
Contributor Author

emilesilvis commented Dec 7, 2019

@phoet yes, but needs work. I'll work on this soon.

If you prefer, I can close the PR and open a new one once I get the time. Let me know.

@emilesilvis
Copy link
Copy Markdown
Contributor Author

@phoet pushed a commit — not sure if it's the most elegant though! Let me know what you think.

@phoet phoet merged commit a9d519c into penseo:master Dec 8, 2019
@phoet
Copy link
Copy Markdown
Contributor

phoet commented Dec 8, 2019

@emilesilvis thx for your contribution, i might make an adjustment, but first i need to test if it works as expected. do you need this as a released gem, or are you working with a fork anyways?

@emilesilvis
Copy link
Copy Markdown
Contributor Author

Thanks @phoet. I don't need a release right now, thanks!

@emilesilvis emilesilvis deleted the feat/live-item-updates branch December 9, 2019 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants