fix(gui): make titlebar options platform-aware for Wayland compatibility#75
Merged
fix(gui): make titlebar options platform-aware for Wayland compatibility#75
Conversation
On Linux Wayland, `appears_transparent: true` and `traffic_light_position` (macOS-specific) interfere with server-side decoration negotiation, preventing window resize, drag, and close/min/max buttons. Gate these options behind `#[cfg(target_os = "macos")]` and extract `default_titlebar_options()` helper to centralize platform-aware titlebar configuration. Closes #68
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
appears_transparent: true,traffic_light_position) behind#[cfg(target_os = "macos")]so they don't interfere with Wayland server-side decoration negotiation on Linuxdefault_titlebar_options()helper inconstants.rsto centralize platform-aware titlebar configuration and eliminate duplication across both window creation sitesCloses #68
Why this approach
The root cause is
appears_transparent: trueinterfering with how Wayland compositors handle server-side decorations (resize handles, drag, close/min/max buttons). Making itfalseon non-macOS platforms fixes the issue without needing to force X11 via environment variable hacks.Test plan
just format— passesjust lint— zero warningsjust test— all tests passappears_transparent: true+traffic_light_positionas before)