Plugin mechanism #345
Merged
Plugin mechanism #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syldb
approved these changes
Aug 6, 2018
| help_text = models.TextField(null=True, blank=True) | ||
| multiple = models.BooleanField(default=False) | ||
| order = models.IntegerField() | ||
| parameters = JSONField(null=True, blank=True, default={}) |
There was a problem hiding this comment.
Why do we need blank and null while there is a default value?
Contributor
Author
There was a problem hiding this comment.
It's a habit for the Django models. When you use it from the admin panel, you can't save a blank field if you haven't specified null=True, blank=True even with a declared default value. Maybe it's an overkill here but I'd like to keep it.
alexdashkov
force-pushed
the
plugin-mechanism
branch
from
4c5a747 to
c141b47
Compare
brunobord
reviewed
Aug 16, 2018
| model_name='field', | ||
| name='parameters', | ||
| field=jsonfield.fields.JSONField( | ||
| blank=True, default={}, null=True |
Contributor
There was a problem hiding this comment.
I think that the best would be to merge this migration with the 0009, and keep its "semantic" name, instead of the automatically generated one.
…lds that go beyond the classical / usual fields available in `django-formidable`. * Added a documentation on how to create a new external field module, * Added a new field in the models to carry the parameters. By default, this field is not (de)serialized, you'll need to activate it by hand as explained in the docs and handle its validation by yourself.
it in the field serializer
alexdashkov
force-pushed
the
plugin-mechanism
branch
from
e750345 to
4aa3835
Compare
Contributor
Author
|
@brunobord do you have some other suggestions? |
brunobord
approved these changes
Aug 20, 2018
Contributor
brunobord
left a comment
brunobord
left a comment
There was a problem hiding this comment.
LGTM. I'll add a warning in the RC changelog about the fact that only the builder is integrated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review
This PR closes #
formidable.ymlfile: runtox -e swagger-staticsto rebuild the swagger static files and commit the diff.CHANGELOG.rstUpdated