Form filler extra fields #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdashkov
approved these changes
Aug 29, 2018
Contributor
alexdashkov
left a comment
alexdashkov
left a comment
There was a problem hiding this comment.
LGTM, just a few comments
formidable/forms/field_builder.py
Outdated
| return field_class(**self.get_field_kwargs()) | ||
|
|
||
| if self.field_is_dict: | ||
| params = self.field.get('parameters', None) |
Contributor
There was a problem hiding this comment.
get('parameters', None) == get('parameters')
formidable/forms/field_builder.py
Outdated
| for key, classpath in extra.items(): | ||
| module_name, class_name = classpath.rsplit('.', 1) | ||
| module = importlib.import_module(module_name) | ||
| field_builder_class = getattr(module, class_name) |
Contributor
There was a problem hiding this comment.
I'd like to move import part to the function in the utils (we will use it to get token in the future)
brunobord
commented
Aug 31, 2018
| import six | ||
|
|
||
|
|
||
| def import_object(object_path): |
Contributor
Author
There was a problem hiding this comment.
great, I love this
brunobord
force-pushed
the
form-filler-extra-fields
branch
from
8a723f5 to
8e7b312
Compare
* Added documentation, * Added a settings-based loading mechanism to extend the `FormFieldFactory` * Added validation mechanism for the dynamically loaded fields
alexdashkov
force-pushed
the
form-filler-extra-fields
branch
from
4ae3af9 to
24d65b9
Compare
syldb
approved these changes
Sep 12, 2018
syldb
left a comment
syldb
left a comment
There was a problem hiding this comment.
LGTM. This context was such a pain! We should remember to be careful when updating DRF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review
CHANGELOG.rstUpdated