Hotfix disable widgets #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
FYI: this will lead to:
|
alexdashkov
approved these changes
Aug 29, 2018
formidable/forms/field_builder.py
Outdated
| # hit, we don't use a get() method in queryset. | ||
| return self.field.accesses.all()[0] | ||
| qs = self.field.accesses.all() | ||
| if qs.exists(): |
Contributor
There was a problem hiding this comment.
I'd like to run only one db request here.
if len(qs):
Contributor
Author
There was a problem hiding this comment.
fair enough. Adding it now.
brunobord
force-pushed
the
hotfix-disable-widgets
branch
from
ac5cc52 to
a9ff0c6
Compare
brunobord
force-pushed
the
hotfix-disable-widgets
branch
from
a9ff0c6 to
fc850e1
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review
This PR is targeting release/2.1 in order to make a new hotfix release
CHANGELOG.rstUpdated