Skip to content

Conversation

@brunobord
Copy link
Contributor

@brunobord brunobord commented Oct 15, 2018

Review

  • Tests
  • Docs/comments
  • CHANGELOG.rst Updated
  • rebase w/autosquash
  • Delete your branch

@alexdashkov
Copy link
Contributor

The code looks good to me, but I do not really understand how we can implement it in the HTML/JSON rendering. Could you explain it to me or/and add some examples?

@brunobord
Copy link
Contributor Author

Could you explain it to me or/and add some examples?

Using FormidableForm instances is the most used way to test Formidable objects and their behaviour outside of their links to business-logic objects. In order to test rendering, we then needed to use the to_formidable() method.
This to_formidable() method creates a whole set of instances. Not using regular formidable fields or widgets would lead to partial data storage (missing items, missing parameters) at runtime.
I wanted to make sure that this part of the django-formidable library API (not the HTTP API, the software API) wouldn't be a blocker when using an external field.

Copy link

@syldb syldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@brunobord brunobord force-pushed the widget-to-formidable-parameters branch from 8e063e1 to b69008a Compare October 17, 2018 12:06
@brunobord brunobord merged commit 678d5b0 into master Oct 17, 2018
@brunobord brunobord deleted the widget-to-formidable-parameters branch October 17, 2018 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants