Skip to content

Conversation

@brunobord
Copy link
Contributor

@brunobord brunobord commented Oct 24, 2019

  • Perf-recs are differentiated,
  • Dev docs updated to explain how to run tests locally,

closes #161

Review

  • Tests
  • Docs/comments
  • CHANGELOG.rst Updated
  • Delete your branch

@brunobord brunobord requested review from mgu and syldb October 24, 2019 08:26
@brunobord
Copy link
Contributor Author

I've got a tiny change to make to make sure the record names are coherent, bare with me.

@brunobord brunobord removed request for mgu and syldb October 24, 2019 08:33
@brunobord brunobord force-pushed the tests-to-run-on-postgresql branch from ddd0bdc to d77ac84 Compare October 24, 2019 09:04
@brunobord brunobord requested review from mgu and syldb October 24, 2019 09:04
@brunobord
Copy link
Contributor Author

better, now.

Copy link
Contributor

@mgu mgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Perf-recs are differentiated,
* Dev docs updated to explain how to run tests locally,

closes #161
@brunobord brunobord force-pushed the tests-to-run-on-postgresql branch from 164cfa2 to d87c3c7 Compare October 24, 2019 13:04
@brunobord brunobord merged commit b34661e into master Oct 24, 2019
@brunobord brunobord deleted the tests-to-run-on-postgresql branch October 24, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Add configuration for PostgreSQL in CircleCI

4 participants