Skip to content

Conversation

@buty4649
Copy link
Contributor

Summary

This PR adds a new --detail flag to the app list command that allows users to retrieve apps with their associated user information.

Changes

  • Add GetAppsDetails method: New method to retrieve apps with user information from OneLogin
  • Introduce AppDetails struct: New data structure that combines app and user data
  • Add --detail flag: New command line flag for enhanced app list output
  • Comprehensive test coverage: Added thorough tests for the new functionality
  • Error handling: Graceful handling of user fetch errors by setting empty user slice

Usage

# List apps with user details
onecli app list --detail

# List apps with user details in JSON format
onecli app list --detail --output json

Testing

  • Added unit tests for GetAppsDetails method
  • Tests cover successful retrieval, empty users, and error scenarios
  • All existing functionality remains unchanged

buty4649 added 3 commits June 18, 2025 12:44
- Add app list-users subcommand to get users for specific apps

- Add comprehensive tests for app functionality

- Refactor mock client to utils package for better reusability
- Add GetAppsDetails method to retrieve apps with user information

- Introduce AppDetails struct to combine app and user data

- Add --detail flag to app list command for enhanced output

- Include comprehensive test coverage for new functionality

- Handle user fetch errors gracefully by setting empty user slice
@buty4649 buty4649 merged commit f94a901 into main Jun 18, 2025
1 check passed
@buty4649 buty4649 deleted the add-app-subcommand branch June 18, 2025 04:15
@github-actions github-actions bot mentioned this pull request Jun 18, 2025
@pepabo-pr-maker pepabo-pr-maker bot mentioned this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants