fix(editor): reload preview as well when initialValue is changing#100
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix the issue where the markdown preview does not reload when the initial content value changes.
- Added a useEffect hook to re-sync the markdown state with the initialValue prop.
Comments suppressed due to low confidence (1)
ui/leafwiki-ui/src/features/editor/MarkdownEditor.tsx:57
- [nitpick] Consider adding a comment above the useEffect hook to explain that it is intended to sync the markdown state with the initialValue prop, ensuring that the preview reloads correctly when the prop changes.
useEffect(() => {
perber
force-pushed
the
fix/97-preview-stays-the-same-after-changing-site
branch
from
324200b to
72e547b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.