refactor: search indexing via pagesave hook#1019
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors search indexing to be driven by the pagesave side-effect hook, using a startup bootstrap to rebuild the index from the tree state and removing the filesystem-based indexer/watcher components.
Changes:
- Replace search bootstrap + fsnotify watcher in
Wiki.initSearch()withpagesave.SearchIndexSideEffect.IndexAllPages(). - Add
IndexAllPages()toSearchIndexSideEffectand introduce unit tests for bootstrap behavior. - Delete the legacy search indexer/bootstrap/watcher implementation and its tests.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/wiki/wiki.go | Switches search bootstrap to SearchIndexSideEffect.IndexAllPages() and removes watcher shutdown logic. |
| internal/wiki/wiki_path_test.go | Removes tests for searchRootDir after deleting that helper. |
| internal/wiki/pagesave/search_effect.go | Adds IndexAllPages() to rebuild the search index from the tree. |
| internal/wiki/pagesave/search_effect_test.go | Adds tests for IndexAllPages() indexing and clearing stale entries. |
| internal/search/watcher.go | Removes filesystem watcher implementation. |
| internal/search/indexer.go | Removes worker-based filesystem indexer. |
| internal/search/indexer_test.go | Removes indexer tests. |
| internal/search/bootstrap.go | Removes BuildAndRunIndexer bootstrap logic. |
| internal/search/bootstrap_test.go | Removes bootstrap tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ec7ebc1 to
539c960
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.