Fix/branding favicon initial html#1025
Merged
Merged
Conversation
Inject the current branding favicon into the initial SPA HTML so the app no longer starts with a hard-coded default favicon reference. Keep the existing client-side favicon updates intact while moving the initial selection into the server-rendered frontend config path.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates LeafWiki’s initial HTML rendering so the favicon can be set from the server-side branding config (instead of always using the built-in /favicon.svg). This aligns the first page load with the configured branding, before the SPA runtime code has a chance to update the favicon.
Changes:
- Replace the hardcoded favicon href in the UI
index.htmlwith a{{__FAVICON_HREF__}}placeholder. - Extend the backend
FrontendConfigto provide the current branding favicon filename and inject the computed favicon href into servedindex.html. - Add a small helper (
BuildFrontendFaviconHref) with unit tests to build the correct favicon URL with/without a base path.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ui/leafwiki-ui/index.html | Switch favicon link to a server-injected placeholder ({{__FAVICON_HREF__}}). |
| internal/wiki/wiki.go | Provide GetFaviconFile via FrontendConfig from branding config. |
| internal/http/router.go | Inject favicon href into HTML and add BuildFrontendFaviconHref. |
| internal/http/router_test.go | Add tests for BuildFrontendFaviconHref. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.