Skip to content

fix(ui): improve editor and asset layouts#1026

Merged
perber merged 2 commits into
mainfrom
fix/mobile-ui-layout
May 24, 2026
Merged

fix(ui): improve editor and asset layouts#1026
perber merged 2 commits into
mainfrom
fix/mobile-ui-layout

Conversation

@perber
Copy link
Copy Markdown
Owner

@perber perber commented May 23, 2026

Tighten the asset manager dialog and make asset rows wrap cleanly on smaller screens. Repair the tree view action trigger so its dropdown menu opens reliably again. Adjust the editor title bar spacing to improve mobile alignment without changing the surrounding header structure.

Tighten the asset manager dialog and make asset rows wrap cleanly on smaller screens. Repair the tree view action trigger so its dropdown menu opens reliably again. Adjust the editor title bar spacing to improve mobile alignment without changing the surrounding header structure.
Copilot AI review requested due to automatic review settings May 23, 2026 23:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines several UI layouts to behave better on smaller screens and fixes an interaction regression in the tree view actions dropdown by making the action button compatible with “asChild”/ref-driven triggers.

Changes:

  • Update Asset Manager list item layout to wrap actions cleanly on small screens and tighten the dialog width.
  • Adjust editor title bar spacing/alignment for improved mobile layout.
  • Refactor TreeViewActionButton to forwardRef and accept native button props for better integration with dropdown triggers.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
ui/leafwiki-ui/src/index.css Updates Tailwind @apply rules for asset rows, asset manager dialog sizing, and editor title bar spacing.
ui/leafwiki-ui/src/features/tree/TreeViewActionButton.tsx Converts to a forwardRef button that spreads native props (used by dropdown triggers).
ui/leafwiki-ui/src/features/assets/AssetItem.tsx Wraps action buttons in a dedicated container and tweaks flex constraints for better wrapping/truncation.
Comments suppressed due to low confidence (1)

ui/leafwiki-ui/src/features/tree/TreeViewActionButton.tsx:30

  • TreeViewActionButton spreads ...props onto the <button> but then overwrites className with a constant. When used with DropdownMenuTrigger asChild (or any consumer passing className), this drops the caller-provided classes and can break styling/behavior that relies on them.
        <button
          {...props}
          ref={ref}
          type={type}
          onClick={(e) => {
            onClick?.(e)
            e.stopPropagation()
          }}
          className="btn-treeview"
          aria-label={tooltip}
          data-testid={`tree-view-action-button-${actionName}`}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ui/leafwiki-ui/src/index.css
@perber perber merged commit bbd146a into main May 24, 2026
6 checks passed
@perber perber deleted the fix/mobile-ui-layout branch May 24, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants