Skip to content

fix(ui): reset metadata dirty state#1027

Merged
perber merged 1 commit into
mainfrom
fix/editor-metadata-dirty-state
May 24, 2026
Merged

fix(ui): reset metadata dirty state#1027
perber merged 1 commit into
mainfrom
fix/editor-metadata-dirty-state

Conversation

@perber
Copy link
Copy Markdown
Owner

@perber perber commented May 24, 2026

Keep metadata-only saves from staying dirty after a successful save. Preserve the two-column metadata layout when only properties exist. Add E2E coverage for saving only properties and removing all properties.

Keep metadata-only saves from staying dirty after a successful save.
Preserve the two-column metadata layout when only properties exist.
Add E2E coverage for saving only properties and removing all properties.
Copilot AI review requested due to automatic review settings May 24, 2026 00:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the editor’s “dirty” state handling for metadata-only saves by ensuring the local editor snapshot is updated canonically after a successful save, even when the API omits empty collections. It also adjusts viewer layout so properties-only metadata keeps the intended two-column alignment, and adds E2E coverage for these scenarios.

Changes:

  • Sync editor store state (page.tags, page.properties, tags, and frontmatterFields) after save to prevent metadata-only saves from remaining dirty.
  • Keep the viewer metadata container in two-column mode when properties exist (even without tags), with a standalone alignment tweak.
  • Add Playwright E2E tests for saving properties-only metadata and removing all properties.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
ui/leafwiki-ui/src/index.css Adds a grid column-start rule to align properties when they’re the only metadata shown in two-column layout.
ui/leafwiki-ui/src/features/viewer/PageMetadata.tsx Applies two-column metadata layout when properties exist and adds a standalone class when tags are absent.
ui/leafwiki-ui/src/features/editor/pageEditorStore.ts Canonicalizes local tags/properties/frontmatter fields after save to correctly reset dirty state for metadata-only updates.
e2e/tests/editor.spec.ts Adds E2E coverage for properties-only saves and removing all properties (verifying UI + API state).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@perber perber merged commit bd21f20 into main May 24, 2026
7 checks passed
@perber perber deleted the fix/editor-metadata-dirty-state branch May 24, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants