fix(ui): reset metadata dirty state#1027
Merged
Merged
Conversation
Keep metadata-only saves from staying dirty after a successful save. Preserve the two-column metadata layout when only properties exist. Add E2E coverage for saving only properties and removing all properties.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the editor’s “dirty” state handling for metadata-only saves by ensuring the local editor snapshot is updated canonically after a successful save, even when the API omits empty collections. It also adjusts viewer layout so properties-only metadata keeps the intended two-column alignment, and adds E2E coverage for these scenarios.
Changes:
- Sync editor store state (
page.tags,page.properties,tags, andfrontmatterFields) after save to prevent metadata-only saves from remaining dirty. - Keep the viewer metadata container in two-column mode when properties exist (even without tags), with a standalone alignment tweak.
- Add Playwright E2E tests for saving properties-only metadata and removing all properties.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ui/leafwiki-ui/src/index.css | Adds a grid column-start rule to align properties when they’re the only metadata shown in two-column layout. |
| ui/leafwiki-ui/src/features/viewer/PageMetadata.tsx | Applies two-column metadata layout when properties exist and adds a standalone class when tags are absent. |
| ui/leafwiki-ui/src/features/editor/pageEditorStore.ts | Canonicalizes local tags/properties/frontmatter fields after save to correctly reset dirty state for metadata-only updates. |
| e2e/tests/editor.spec.ts | Adds E2E coverage for properties-only saves and removing all properties (verifying UI + API state). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep metadata-only saves from staying dirty after a successful save. Preserve the two-column metadata layout when only properties exist. Add E2E coverage for saving only properties and removing all properties.