feat(deps): remove blackfriday markdown parser dependency#1030
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the blackfriday Markdown parser dependency by switching Markdown-to-text extraction and heading parsing to goldmark, aligning search indexing and excerpt generation with the already-present goldmark dependency in the codebase.
Changes:
- Replace
blackfriday-based heading extraction in the SQLite search indexer with agoldmarkAST walk. - Replace
blackfriday.Runinexcerpt.PlainTextFromMarkdownwithgoldmark.Convert+ sanitization. - Remove
blackfriday(and now-unusedfsnotify) fromgo.mod/go.sum, and add unit tests covering heading extraction behavior.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/search/sqlite_index.go | Migrates heading extraction from Blackfriday to Goldmark AST parsing for search indexing. |
| internal/search/sqlite_index_test.go | Adds focused tests for extractHeadings to validate expected heading-only extraction and formatting stripping. |
| internal/core/excerpt/excerpt.go | Migrates Markdown-to-plain-text conversion from Blackfriday to Goldmark while keeping HTML sanitization. |
| go.mod | Removes Blackfriday (and unused fsnotify) dependencies; retains Goldmark. |
| go.sum | Cleans up checksums corresponding to removed dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
daca902 to
3b77a73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.