Skip to content

feat(deps): remove blackfriday markdown parser dependency#1030

Merged
perber merged 1 commit into
mainfrom
feature/remove-blackfriday-parser
May 24, 2026
Merged

feat(deps): remove blackfriday markdown parser dependency#1030
perber merged 1 commit into
mainfrom
feature/remove-blackfriday-parser

Conversation

@perber
Copy link
Copy Markdown
Owner

@perber perber commented May 24, 2026

No description provided.

Copilot AI review requested due to automatic review settings May 24, 2026 02:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the blackfriday Markdown parser dependency by switching Markdown-to-text extraction and heading parsing to goldmark, aligning search indexing and excerpt generation with the already-present goldmark dependency in the codebase.

Changes:

  • Replace blackfriday-based heading extraction in the SQLite search indexer with a goldmark AST walk.
  • Replace blackfriday.Run in excerpt.PlainTextFromMarkdown with goldmark.Convert + sanitization.
  • Remove blackfriday (and now-unused fsnotify) from go.mod/go.sum, and add unit tests covering heading extraction behavior.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/search/sqlite_index.go Migrates heading extraction from Blackfriday to Goldmark AST parsing for search indexing.
internal/search/sqlite_index_test.go Adds focused tests for extractHeadings to validate expected heading-only extraction and formatting stripping.
internal/core/excerpt/excerpt.go Migrates Markdown-to-plain-text conversion from Blackfriday to Goldmark while keeping HTML sanitization.
go.mod Removes Blackfriday (and unused fsnotify) dependencies; retains Goldmark.
go.sum Cleans up checksums corresponding to removed dependencies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@perber perber force-pushed the feature/remove-blackfriday-parser branch from daca902 to 3b77a73 Compare May 24, 2026 02:40
@perber perber merged commit 4fabf8a into main May 24, 2026
6 checks passed
@perber perber deleted the feature/remove-blackfriday-parser branch May 24, 2026 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants