test(e2e): verify imported metadata#1031
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an E2E regression test to ensure the ZIP importer correctly brings in page frontmatter metadata (tags + custom properties) and that it’s visible in both the viewer metadata widget and the editor’s frontmatter panel.
Changes:
- Add a new importer fixture page containing tags and custom properties for verification.
- Extend importer Playwright E2E coverage to assert imported tags/properties in viewer and editor.
- Make the importer “plan created” toast assertion resilient to multiple matching toasts.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| internal/importer/fixtures/import-metadata-package/home.md | Adds a metadata-bearing fixture page used for E2E verification. |
| e2e/tests/importer.spec.ts | Adds an E2E test that imports a metadata ZIP and checks tags/properties in viewer + editor. |
| e2e/pages/ImporterPage.ts | Adjusts toast locator to target the latest matching “plan created” message. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.