fix: italic shortcut#1039
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a Chrome-specific conflict where the browser’s native rich-text formatting (via beforeinput) can interfere with CodeMirror’s Markdown bold/italic shortcuts, and adds E2E coverage plus stable selectors for toolbar formatting buttons.
Changes:
- Added
beforeinputDOM event handling in the CodeMirror editor to prevent nativeformatBold/formatItalicbehavior. - Added
data-testidattributes for Bold/Italic toolbar buttons to support reliable E2E selection. - Added Playwright E2E tests covering bold/italic formatting via both keyboard shortcuts and toolbar buttons.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ui/leafwiki-ui/src/features/editor/MarkdownToolbar.tsx | Adds data-testid hooks for bold/italic toolbar buttons used by E2E tests. |
| ui/leafwiki-ui/src/features/editor/MarkdownCodeEditor.tsx | Prevents Chrome beforeinput formatting actions (formatItalic/formatBold) so CodeMirror shortcuts work reliably. |
| e2e/tests/editor.spec.ts | Adds E2E coverage verifying bold/italic insertion works via keyboard and toolbar. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.