feat: fail on missing trusted proxy ips#1068
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a fail-fast configuration check so reverse-proxy authentication via --enable-http-remote-user cannot be enabled without explicitly configuring trusted proxy IPs/CIDRs.
Changes:
- Add
validateHTTPRemoteUserConfig(...)and call it during startup. - Introduce unit tests for the new validation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cmd/leafwiki/main.go | Adds startup validation requiring --trusted-proxy-ips when HTTP remote-user auth is enabled. |
| cmd/leafwiki/main_test.go | Adds a table-driven test for validateHTTPRemoteUserConfig. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…-trusted-proxy-ips
perber
force-pushed
the
feat/fail-on-missing-trusted-proxy-ips
branch
from
cf12276 to
531a370
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.