Skip to content

add full-text search support#73

Merged
perber merged 36 commits into
mainfrom
feature/search
Jun 13, 2025
Merged

add full-text search support#73
perber merged 36 commits into
mainfrom
feature/search

Conversation

@perber
Copy link
Copy Markdown
Owner

@perber perber commented Jun 7, 2025

No description provided.

@perber perber linked an issue Jun 7, 2025 that may be closed by this pull request
@perber perber added this to the v0.4.0 milestone Jun 9, 2025
@perber perber marked this pull request as ready for review June 9, 2025 19:50
Copilot AI review requested due to automatic review settings June 9, 2025 19:50

This comment was marked as outdated.

@perber perber requested a review from Copilot June 9, 2025 20:24

This comment was marked as outdated.

@perber perber requested a review from Copilot June 9, 2025 20:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds full‐text search support to the application along with several related updates such as new API endpoints, indexer and watcher implementations, and integration into the Wiki service.

  • Adds search endpoints and search status API in HTTP router and handler files
  • Implements a new SQLite-based full-text index along with a file watcher and indexer
  • Updates tests and various Wiki initialization calls to support the new search indexing option

Reviewed Changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ui/leafwiki-ui/src/components/TreeViewActionButton.tsx Updated button markup for better accessibility and styling
ui/leafwiki-ui/src/components/Pagination.tsx Introduced a new pagination component
internal/wiki/wiki.go Modified Wiki initialization and Close() to integrate search indexing
internal/search/* Added new search index, watcher, indexer, and bootstrap functionality
internal/http/api/search*.go Created API endpoints for search status and search queries
internal/http/router*.go Extended router configuration to include search routes
internal/core/tree/tree_service.go Added CalculatePath() helper for page nodes
go.mod, cmd/leafwiki/main.go Updated dependencies and Wiki instantiation to support search
Comments suppressed due to low confidence (1)

internal/core/tree/tree_service.go:48

  • [nitpick] Clarify the handling of empty parent paths to ensure that concatenating paths does not result in an unintended leading slash. Adding a comment or refactoring the logic may improve maintainability and clarity.
func (p *PageNode) CalculatePath() string {

Comment thread internal/search/sqlite_index.go
Comment thread internal/wiki/wiki.go
@perber perber changed the base branch from main to release/v0.4.0 June 12, 2025 17:21
@perber perber changed the base branch from release/v0.4.0 to main June 13, 2025 12:39
@perber perber merged commit e0cf0e3 into main Jun 13, 2025
4 checks passed
@perber perber deleted the feature/search branch June 13, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search

2 participants