feat: add linux/arm64 build and release support#75
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for building and releasing a linux/arm64 binary alongside existing platforms.
- Updated Makefile to include linux/arm64 in the build targets
- Enhanced the GitHub release workflow to upload the ARM64 binary and checksum
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Makefile | Added linux/arm64 to PLATFORMS for ARM builds |
| .github/workflows/release.yml | Included ARM64 artifacts in the release upload |
Comments suppressed due to low confidence (1)
Makefile:7
- Update this comment to reflect the addition of linux/arm64, e.g.,
# At the moment we can test on linux/amd64, linux/arm64, and windows/amd64.
# At the moment we only can test it on linux/amd64 and windows/amd64
Owner
|
@nahaktarun Thanks! Your change is looking good. I will test it the upcoming days and leave it open until I tried it on my raspi. |
Closed
Owner
|
I tested it via the Docker: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #71
Feature change:
How to test:
docker buildx create --use --name multiarch.docker run --rm -it --platform linux/arm64 \ -v "$(pwd)":/app \ ubuntu:22.04 \ /app/releases/leafwiki-v0.1.0-linux-arm64 --helpFeel free to review and test .