fix(ui): harden config load errors#859
Merged
Merged
Conversation
Show config load failures in the UI without exposing arbitrary non-JSON response bodies. Preserve structured API error messages such as the insecure HTTP guidance while falling back to generic status errors for unexpected responses.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens how the UI surfaces /api/config load failures by displaying structured API error messages when available, while avoiding leaking arbitrary non-JSON response bodies to users.
Changes:
- Adds
errorstate to the config store and populates it when config loading fails. - Updates
getConfig()to preferentially extracterror/messagefrom JSON error responses and otherwise fall back to a generic status-based error. - Displays config load failures via a toast and ensures the toast system is mounted during initial bootstrap.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ui/leafwiki-ui/src/stores/config.ts | Tracks config load error state and exposes it via Zustand store. |
| ui/leafwiki-ui/src/lib/api/config.ts | Implements safer error parsing for non-OK config responses. |
| ui/leafwiki-ui/src/App.tsx | Shows config load errors via toast and mounts the toaster during bootstrap/refresh gating. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Use the fallback config error message when the API returns a non-JSON error body. Keep the toaster mounted and allow the same config error to be shown again after a retry so startup failures remain visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show config load failures in the UI without exposing arbitrary non-JSON response bodies. Preserve structured API error messages such as the insecure HTTP guidance while falling back to generic status errors for unexpected responses.