feat(install): Add new argument from V9 in installer.#954
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Linux installer and configuration templates to expose newly added LeafWiki v0.9.x environment/CLI options (primarily revision history and related limits), plus a small README clarification about supported distros.
Changes:
- Add revision-history related variables to the installer flow and
.env.example(LEAFWIKI_ENABLE_REVISION,LEAFWIKI_MAX_REVISION_HISTORY). - Introduce plumbing for link refactor configuration in the installer (
LEAFWIKI_ENABLE_LINK_REFACTOR). - Update README to state the installer has been tested on Ubuntu, Debian, and Raspbian.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| readme.md | Expands the “tested on” distro list for the installer. |
| install.sh | Adds non-interactive env parsing + interactive prompts for revision history settings. |
| .env.example | Documents new env vars for revision history and link refactor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Hugo-Galley
force-pushed
the
feature/enhance-installer
branch
from
e2e2d62 to
c4290b6
Compare
Hugo-Galley
force-pushed
the
feature/enhance-installer
branch
from
c4290b6 to
064827a
Compare
Owner
|
Hi @Hugo-Galley, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @perber,
After the v9 release, I thought we could improve the installer to support the latest flags that were added.
It now supports flags for:
I decided not to include permalinks in the interactive installation flow to avoid overloading it. Does that choice make sense to you?