fix: the editor isn't taking the whole place#99
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a layout issue where the editor was not expanding to use the full available space.
- Adjusts the container div to include "flex-1" so that it grows as needed.
- Updates both the editor and preview container classes to support full height expansion.
Comments suppressed due to low confidence (2)
ui/leafwiki-ui/src/features/editor/MarkdownEditor.tsx:297
- The addition of 'flex-1' on the parent container seems to fix the expansion issue, but please ensure that it does not introduce layout issues in other contexts. Consider adding a brief inline comment to explain its necessity.
<div className="flex w-full overflow-hidden flex-1">
ui/leafwiki-ui/src/features/editor/MarkdownEditor.tsx:298
- Including both 'w-1/2' and 'flex-1' on the child container ensures balanced sizing while allowing vertical expansion; please verify that this combination aligns with the overall responsive design strategy.
<div className="w-1/2 flex flex-1 max-w-none overflow-auto">
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.