Skip to content

fix: the editor isn't taking the whole place#99

Merged
perber merged 2 commits into
mainfrom
fix/96-the-editor-isnt-takeing-the-whole-place
Jun 17, 2025
Merged

fix: the editor isn't taking the whole place#99
perber merged 2 commits into
mainfrom
fix/96-the-editor-isnt-takeing-the-whole-place

Conversation

@perber
Copy link
Copy Markdown
Owner

@perber perber commented Jun 17, 2025

No description provided.

Copilot AI review requested due to automatic review settings June 17, 2025 21:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a layout issue where the editor was not expanding to use the full available space.

  • Adjusts the container div to include "flex-1" so that it grows as needed.
  • Updates both the editor and preview container classes to support full height expansion.
Comments suppressed due to low confidence (2)

ui/leafwiki-ui/src/features/editor/MarkdownEditor.tsx:297

  • The addition of 'flex-1' on the parent container seems to fix the expansion issue, but please ensure that it does not introduce layout issues in other contexts. Consider adding a brief inline comment to explain its necessity.
        <div className="flex w-full overflow-hidden flex-1">

ui/leafwiki-ui/src/features/editor/MarkdownEditor.tsx:298

  • Including both 'w-1/2' and 'flex-1' on the child container ensures balanced sizing while allowing vertical expansion; please verify that this combination aligns with the overall responsive design strategy.
          <div className="w-1/2 flex flex-1 max-w-none overflow-auto">

@perber perber linked an issue Jun 17, 2025 that may be closed by this pull request
@perber perber merged commit c14718c into main Jun 17, 2025
4 checks passed
@perber perber deleted the fix/96-the-editor-isnt-takeing-the-whole-place branch June 17, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Editor isn't taking the whole place when the page hasn't much content

2 participants