-
Notifications
You must be signed in to change notification settings - Fork 11
Pytorch Lightning 2 compatibility #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The argument was remove in torchmetrics v0.9. Keep the argument in __init__ for backward compatibility only.
|
Hello @percevalw, thanks for this update! I've tested the integration with medkit, and it seems to work fine. |
|
Yes ofc ! I was waiting for your feedback, I'll do it asap |
|
Great to hear this is moving forward. Thank you- 🙏 As a side note:
Not really. Versions 3.6 and 3.7 are no longer supported and are being progressively dropped by libraries. |
|
@camila-ud we would also need #17, similar situation as with |
|
Yes, indeed. The license should also be updated in order to be compatible with more projects. I would be grateful if you could include the modifications from #17 in the release. I am just finishing the details of the operation, but I would like to integrate it soon. |
|
It depends. Indeed, py37 is no longer supported, but some cluster environments have incompatibilities with py38 and above (for example spark 2 clusters). I prefer to support these versions as long as there are no major incompatibilities. For reference, here are the pip package download statistics by python version (excluding universal/source package downloads) over the last month, with py37 in second place!
|
|
@ghisvail @camila-ud the new version 0.2.0 has just been released, thank you both for your contributions ! |
|
Awesome, thanks for addressing our issues so quickly. |
|
My pleasure ! Consider leaving a star if you end up finding it useful in your work |
Going a bit further than #15, this PR relaxes all the upper bounds of the requirements:
python: keep>=3.6(but most projects usepython>=3.7anyway)einops: from~=0.3.0to>=0.3.0tqdm: from~=4.56.0to>=4.56.0pytorch_lightning: from>=1.1.7,<=1.4.9to>=1.1.7torchmetrics: from==0.7.3to>=0.7.3rich_logger: from>=0.1.4to>=0.3.1sentencepiece: from~=0.1.95to>=0.1.95xxhash: from~=2.0.0to>=2.0.0regex: from~=2020.11.13to>=2020.11.13parse: from~=1.19.0to>=1.19.0and ensures that models can still be trained under
pytorch-ligthning==1.*orpytorch-ligthning==2.*.I've tested this under python 3.7, 3.8 and 3.10, with oldest & latest requirements.
Additionally, from
rich-logger>=0.3.1, nested tqdm progress bars are rendered nicely with rich, so I added them back.@camila-ud do you want to pull & check if this works for you ?