Skip to content

PMM-14404 - Enhance PBM backup metrics collection by including cluste… #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 20, 2025
Merged

PMM-14404 - Enhance PBM backup metrics collection by including cluste… #1181

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
77ca094
PMM-14404 - Enhance PBM backup metrics collection by including cluste…
theTibi Oct 15, 2025
1b81c71
Refactor PBM backup metrics collection to streamline node information…
theTibi Oct 15, 2025
5642f84
Enhance PBM backup metrics collection with detailed logging and impro…
theTibi Oct 15, 2025
708bfa8
Revert "Enhance PBM backup metrics collection with detailed logging a…
theTibi Oct 16, 2025
5574603
Refactor PBM metrics collection to utilize current node information
theTibi Oct 16, 2025
4b44ef2
Merge branch 'main' into PMM-14404
theTibi Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 52 additions & 45 deletions exporter/pbm_collector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import (
"github.com/prometheus/client_golang/prometheus"
"go.mongodb.org/mongo-driver/mongo"

"github.com/percona/mongodb_exporter/internal/proto"
"github.com/percona/mongodb_exporter/internal/util"
)

Expand Down Expand Up @@ -113,8 +114,14 @@ func (p *pbmCollector) collect(ch chan<- prometheus.Metric) {
"PBM PITR backups are enabled for the cluster",
float64(pitrEnabledMetric), nil))

metrics = append(metrics, p.pbmBackupsMetrics(p.ctx, pbmClient, logger)...)
metrics = append(metrics, p.pbmAgentMetrics(p.ctx, pbmClient, logger)...)
// Get current node info once for both agent and backup metrics
currentNode, err := util.MyRole(p.ctx, p.base.client)
if err != nil {
logger.Error("failed to get current node info", "error", err.Error())
} else {
metrics = append(metrics, p.pbmBackupsMetrics(p.ctx, pbmClient, logger, currentNode)...)
metrics = append(metrics, p.pbmAgentMetrics(p.ctx, pbmClient, logger, currentNode)...)
}
}

metrics = append(metrics, createPBMMetric("cluster_backup_configured",
Expand All @@ -126,13 +133,7 @@ func (p *pbmCollector) collect(ch chan<- prometheus.Metric) {
}
}

func (p *pbmCollector) pbmAgentMetrics(ctx context.Context, pbmClient *sdk.Client, l *slog.Logger) []prometheus.Metric {
currentNode, err := util.MyRole(ctx, p.base.client)
if err != nil {
l.Error("failed to get current node info", "error", err.Error())
return nil
}

func (p *pbmCollector) pbmAgentMetrics(ctx context.Context, pbmClient *sdk.Client, l *slog.Logger, currentNode *proto.HelloResponse) []prometheus.Metric {
clusterStatus, err := cli.ClusterStatus(ctx, pbmClient, cli.RSConfGetter(p.mongoURI))
if err != nil {
l.Error("failed to get cluster status", "error", err.Error())
Expand Down Expand Up @@ -174,7 +175,7 @@ func (p *pbmCollector) pbmAgentMetrics(ctx context.Context, pbmClient *sdk.Clien
return metrics
}

func (p *pbmCollector) pbmBackupsMetrics(ctx context.Context, pbmClient *sdk.Client, l *slog.Logger) []prometheus.Metric {
func (p *pbmCollector) pbmBackupsMetrics(ctx context.Context, pbmClient *sdk.Client, l *slog.Logger, currentNode *proto.HelloResponse) []prometheus.Metric {
backupsList, err := pbmClient.GetAllBackups(ctx)
if err != nil {
l.Error("failed to get PBM backup list", "error", err.Error())
Expand All @@ -184,42 +185,48 @@ func (p *pbmCollector) pbmBackupsMetrics(ctx context.Context, pbmClient *sdk.Cli
metrics := make([]prometheus.Metric, 0, len(backupsList))

for _, backup := range backupsList {
metrics = append(metrics, createPBMMetric("backup_size_bytes",
"Size of PBM backup",
float64(backup.Size), map[string]string{
"opid": backup.OPID,
"status": string(backup.Status),
"name": backup.Name,
}),
)

// Add backup_last_transition_ts metric
metrics = append(metrics, createPBMMetric("backup_last_transition_ts",
"Last transition timestamp of PBM backup (seconds since epoch)",
float64(backup.LastTransitionTS), map[string]string{
"opid": backup.OPID,
"status": string(backup.Status),
"name": backup.Name,
}),
)

var endTime int64
switch pbmAgentStatus(backup.Status) {
case statusDone, statusCancelled, statusError, statusDown:
endTime = backup.LastTransitionTS
default:
endTime = time.Now().Unix()
}
// Iterate through replsets in the backup metadata
for _, replset := range backup.Replsets {
// Determine if this is the current node
self := "0"
if replset.Node == currentNode.Me {
self = "1"
}

duration := time.Unix(endTime-backup.StartTS, 0).Unix()
metrics = append(metrics, createPBMMetric("backup_duration_seconds",
"Duration of PBM backup",
float64(duration), map[string]string{
"opid": backup.OPID,
"status": string(backup.Status),
"name": backup.Name,
}),
)
labels := map[string]string{
"opid": backup.OPID,
"status": string(backup.Status),
"name": backup.Name,
"host": replset.Node,
"replica_set": replset.Name,
"self": self,
}

metrics = append(metrics, createPBMMetric("backup_size_bytes",
"Size of PBM backup",
float64(backup.Size), labels),
)

// Add backup_last_transition_ts metric
metrics = append(metrics, createPBMMetric("backup_last_transition_ts",
"Last transition timestamp of PBM backup (seconds since epoch)",
float64(backup.LastTransitionTS), labels),
)

var endTime int64
switch pbmAgentStatus(backup.Status) {
case statusDone, statusCancelled, statusError, statusDown:
endTime = backup.LastTransitionTS
default:
endTime = time.Now().Unix()
}

duration := time.Unix(endTime-backup.StartTS, 0).Unix()
metrics = append(metrics, createPBMMetric("backup_duration_seconds",
"Duration of PBM backup",
float64(duration), labels),
)
}
}
return metrics
}
Expand Down