fix: use useradd instead of adduser for cross-version compatibility #1182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace adduser with useradd for mongodb_exporter user creation. The --comment option in adduser is not supported in Debian 11, only in Debian 12+. useradd works consistently across all versions.
izmal
requested review from
JiriCtvrtka and
idoqo
and removed request for
a team
|
|
Member
|
Hi @izmal! Could you please sign the CLA (see link above)? |
ademidoff
approved these changes
Oct 16, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1182 +/- ##
==========================================
- Coverage 70.88% 65.13% -5.76%
==========================================
Files 28 29 +1
Lines 3569 3095 -474
==========================================
- Hits 2530 2016 -514
- Misses 904 939 +35
- Partials 135 140 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JiriCtvrtka
approved these changes
Oct 19, 2025
Contributor
|
@izmal Thank you for your contribution. |
|
It would be great if a new release including this fix could be cut, otherwise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace adduser with useradd for mongodb_exporter user creation. The --comment option in adduser is not supported in Debian 11, only in Debian 12+. useradd works consistently across all versions.
related #1153