PMM-14431 More complex check if it is real count type or not. #1195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiriCtvrtka
force-pushed
the
PMM-14431-mongo-count-mismatch
branch
from
d56ff3c to
c9afe29
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return res | ||
| } | ||
|
|
||
| func handleMetricSwitch(reservedNames []string, prefix, nextPrefix, k string, val interface{}, l map[string]string, compatibleMode bool) []prometheus.Metric { |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
calculated cyclomatic complexity for function handleMetricSwitch is 12, max is 10 (cyclop)
JiriCtvrtka
changed the title
JiriCtvrtka
requested review from
BupycHuk,
ademidoff and
idoqo
and removed request for
a team
ademidoff
reviewed
Nov 25, 2025
Member
ademidoff
left a comment
ademidoff
left a comment
There was a problem hiding this comment.
I'm seeing GetAllIndexesForCollections being called in multiple collectors. This call is rather expensive. Would it be beneficial to cache it for a short period of time?
exporter/metrics.go
Outdated
| if err != nil { | ||
| continue // skip collections where indexes cannot be listed (e.g., views, system collections) | ||
| } | ||
| defer cursor.Close(ctx) //nolint:errcheck |
Member
There was a problem hiding this comment.
I don't think this would be the best to run defer in a loop within this context. Can we declare the cursor variable outside of the loop and defer once?
Contributor
Author
There was a problem hiding this comment.
Good point. Moved to the end since there are multiple cursors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-14431
FB: Percona-Lab/pmm-submodules#4118