PMM-8770 enable safe metrics collection #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my local I have go 1.17 so the sum was different and tests were failing.
Now discovering mode automatically search for all databases and all collections. It might receive a filter list and ignores system collections.
percona-csalguero
changed the title
percona-csalguero
requested review from
BupycHuk,
JiriCtvrtka and
floatinginbits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| var stats []bson.M | ||
| if err = cursor.All(d.ctx, &stats); err != nil { | ||
| d.logger.Errorf("cannot get $indexStats for collection %s.%s: %s", database, collection, err) | ||
|
|
BupycHuk
approved these changes
Dec 1, 2021
main.go
Outdated
| DisableDiagnosticData bool `name:"no-collector.diagnosticdata" help:"Disable collecting metrics from getDiagnosticData"` | ||
| DisableReplicasetStatus bool `name:"no-collector.replicasetstatus" help:"Disable collecting metrics from replSetGetStatus"` | ||
| EnableDBStats bool `name:"collector.dbstats" help:"Enable collecting metrics from dbStats"` | ||
| CollStatsLimit int `name:"collector.collstats-limit" help:"Enable collstats and indexstats collector only if there are less than <n> collections. -1=No limit" default:"100"` |
Member
There was a problem hiding this comment.
I would set no limit by default.
Member
There was a problem hiding this comment.
And if we need limit in PMM set it there.
Member
|
Please fix all golint issues |
JiriCtvrtka
approved these changes
Dec 1, 2021
floatinginbits
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-8770: Enable safe Collection metrics collection for MongoDB
Feature Build: PR #2154