Skip to content

PS-9760 Remove the clang-tidy github workflow check (8.4)#5654

Merged
VarunNagaraju merged 2 commits intopercona:8.4from
VarunNagaraju:PS-9040-revert-8.4
Jul 15, 2025
Merged

PS-9760 Remove the clang-tidy github workflow check (8.4)#5654
VarunNagaraju merged 2 commits intopercona:8.4from
VarunNagaraju:PS-9040-revert-8.4

Conversation

@VarunNagaraju
Copy link
Copy Markdown
Contributor

https://perconadev.atlassian.net/browse/PS-9760

The clang-tidy github workflow check was added as part of PS-9040 in order to do the static analysis and post the suggested changes as PR comments since it spammed the comment section at times.

The same check is now part of the circleCI check which keeps the PR clean while the suggested changes can seen in the circleCI log.

https://perconadev.atlassian.net/browse/PS-9760

The clang-tidy github workflow check was added as part of PS-9040 in
order to do the static analysis and post the suggested changes as PR
comments since it spammed the comment section at times.

The same check is now part of the circleCI check which keeps the PR
clean while the suggested changes can seen in the circleCI log.
Copy link
Copy Markdown
Collaborator

@percona-ysorokin percona-ysorokin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VarunNagaraju VarunNagaraju merged commit c14967a into percona:8.4 Jul 15, 2025
22 checks passed
inikep added a commit that referenced this pull request Jul 18, 2025
…unNagaraju/PS-9040-revert-8.4) into trunk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants