PMM-7 Migrate golangci-lint to v2#1221
Open
ademidoff wants to merge 2 commits into
Open
Conversation
maxkondr
reviewed
May 21, 2026
| run: | | ||
| # use GITHUB_TOKEN because only it has access to GitHub Checks API | ||
| bin/golangci-lint run --out-format=line-number | env REVIEWDOG_GITHUB_API_TOKEN=${{ secrets.GITHUB_TOKEN }} bin/reviewdog -f=golangci-lint -reporter=github-pr-review -filter-mode=added -fail-level=error | ||
| bin/golangci-lint run --output.text.path=stdout --output.text.print-issued-lines=false --output.text.colors=false | env REVIEWDOG_GITHUB_API_TOKEN=${{ secrets.GITHUB_TOKEN }} bin/reviewdog -f=golangci-lint -reporter=github-pr-review -filter-mode=added -fail-level=error |
Contributor
There was a problem hiding this comment.
why not to switch to unified approach that we use:
- name: Run code linters
uses: reviewdog/action-golangci-lint@c76cceaaab89abe74e649d2e34c6c9adc26662d2 # v2.10.0
with:
github_token: ${{ secrets.ROBOT_TOKEN || secrets.GITHUB_TOKEN }}
go_version_file: ${{ github.workspace }}/go.mod
reporter: github-pr-review
fail_level: error
cache: false
golangci_lint_flags: "-c=.golangci.yml"
golangci_lint_version: v2.12.2 # Version should match specified in Makefile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request upgrades the project to use
golangci-lintv2 and updates the linter configuration to the new version's format. The workflow for running linters in CI is adjusted for the new linter output format.Upgrade to golangci-lint v2 and configuration changes:
golangci-lintv1.x togolangci-lint/v2v2.12.2..golangci.ymlto the new v2 configuration format.CI workflow update:
golangci-lintv2 output flags (--output.text.path=stdout, etc.), ensuring compatibility withreviewdog.