This repository was archived by the owner on Jun 21, 2022. It is now read-only.
PMM-4013 SHOW TABLE Action. #207
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,3 +3,4 @@ | |
| /bin/ | ||
| cover.out | ||
| crosscover.out | ||
| packages.png | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| // pmm-managed | ||
| // Copyright (C) 2017 Percona LLC | ||
| // | ||
| // This program is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU Affero General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
| // | ||
| // This program is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU Affero General Public License for more details. | ||
| // | ||
| // You should have received a copy of the GNU Affero General Public License | ||
| // along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
|
|
||
| package models | ||
|
|
||
| import ( | ||
| "github.com/google/uuid" | ||
| "google.golang.org/grpc/codes" | ||
| "google.golang.org/grpc/status" | ||
| "gopkg.in/reform.v1" | ||
| ) | ||
|
|
||
| // CreateActionResult stores an action result in action results storage. | ||
| func CreateActionResult(q *reform.Querier, pmmAgentID string) (*ActionResult, error) { | ||
| result := &ActionResult{ID: "/action_id/" + uuid.New().String(), PmmAgentID: pmmAgentID} | ||
| if err := q.Insert(result); err != nil { | ||
| return result, status.Errorf(codes.FailedPrecondition, "Couldn't create ActionResult, reason: %v", err) | ||
| } | ||
|
|
||
| return result, nil | ||
| } | ||
|
|
||
| // ChangeActionResult updates an action result in action results storage. | ||
| func ChangeActionResult(q *reform.Querier, actionID, pmmAgentID, aError, output string, done bool) error { | ||
|
There was a problem hiding this comment. U1000: func |
||
| result := &ActionResult{ | ||
| ID: actionID, | ||
| PmmAgentID: pmmAgentID, | ||
| Done: done, | ||
| Error: aError, | ||
| Output: output, | ||
| } | ||
| if err := q.Update(result); err != nil { | ||
| return status.Errorf(codes.FailedPrecondition, "Couldn't update ActionResult, reason: %v", err) | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| // FindActionResultByID loads an action result from storage by action id. | ||
| func FindActionResultByID(q *reform.Querier, id string) (*ActionResult, error) { | ||
| if id == "" { | ||
| return nil, status.Errorf(codes.InvalidArgument, "Couldn't get AgentResult, as id is empty.") | ||
| } | ||
|
|
||
| row := &ActionResult{ID: id} | ||
| switch err := q.Reload(row); err { | ||
| case nil: | ||
| return row, nil | ||
| case reform.ErrNoRows: | ||
| return nil, status.Errorf(codes.NotFound, "ActionResult with ID %q not found.", id) | ||
| default: | ||
| return nil, status.Errorf(codes.FailedPrecondition, "Couldn't get AgentResult, reason: %v", err) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| // pmm-managed | ||
| // Copyright (C) 2017 Percona LLC | ||
| // | ||
| // This program is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU Affero General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
| // | ||
| // This program is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU Affero General Public License for more details. | ||
| // | ||
| // You should have received a copy of the GNU Affero General Public License | ||
| // along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
|
|
||
| package models_test | ||
|
|
||
| import ( | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| "gopkg.in/reform.v1" | ||
| "gopkg.in/reform.v1/dialects/postgresql" | ||
|
|
||
| "github.com/percona/pmm-managed/models" | ||
| "github.com/percona/pmm-managed/utils/testdb" | ||
| ) | ||
|
|
||
| func TestActionHelpers(t *testing.T) { | ||
| now, origNowF := models.Now(), models.Now | ||
| models.Now = func() time.Time { | ||
| return now | ||
| } | ||
| sqlDB := testdb.Open(t) | ||
| defer func() { | ||
| models.Now = origNowF | ||
| require.NoError(t, sqlDB.Close()) | ||
| }() | ||
|
|
||
| setup := func(t *testing.T) (q *reform.Querier, teardown func(t *testing.T)) { | ||
| db := reform.NewDB(sqlDB, postgresql.Dialect, reform.NewPrintfLogger(t.Logf)) | ||
| tx, err := db.Begin() | ||
| require.NoError(t, err) | ||
| q = tx.Querier | ||
|
|
||
| for _, str := range []reform.Struct{ | ||
| &models.ActionResult{ | ||
| ID: "A1", | ||
| PmmAgentID: "A2", | ||
| }, | ||
| } { | ||
| require.NoError(t, q.Insert(str)) | ||
| } | ||
|
|
||
| teardown = func(t *testing.T) { | ||
| require.NoError(t, tx.Rollback()) | ||
| } | ||
| return | ||
| } | ||
|
|
||
| t.Run("FindActionResultByID", func(t *testing.T) { | ||
| q, teardown := setup(t) | ||
| defer teardown(t) | ||
|
|
||
| a, err := models.FindActionResultByID(q, "A1") | ||
| require.NoError(t, err) | ||
| assert.NotEmpty(t, a.ID) | ||
|
|
||
| _, err = models.FindActionResultByID(q, "A2") | ||
| require.Error(t, err) | ||
| }) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| // pmm-managed | ||
| // Copyright (C) 2017 Percona LLC | ||
| // | ||
| // This program is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU Affero General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
| // | ||
| // This program is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU Affero General Public License for more details. | ||
| // | ||
| // You should have received a copy of the GNU Affero General Public License | ||
| // along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
|
|
||
| package models | ||
|
|
||
| import ( | ||
| "time" | ||
|
|
||
| "gopkg.in/reform.v1" | ||
| ) | ||
|
|
||
| //go:generate reform | ||
|
|
||
| // ActionResult describes an action result which is storing in persistent storage. | ||
| //reform:action_results | ||
| type ActionResult struct { | ||
| ID string `reform:"id,pk"` | ||
| PmmAgentID string `reform:"pmm_agent_id"` | ||
| Done bool `reform:"done"` | ||
| Error string `reform:"error"` | ||
| Output string `reform:"output"` | ||
| CreatedAt time.Time `reform:"created_at"` | ||
| UpdatedAt time.Time `reform:"updated_at"` | ||
| } | ||
|
|
||
| // BeforeInsert implements reform.BeforeInserter interface. | ||
| func (s *ActionResult) BeforeInsert() error { | ||
| now := Now() | ||
| s.CreatedAt = now | ||
| s.UpdatedAt = now | ||
| return nil | ||
| } | ||
|
|
||
| // BeforeUpdate implements reform.BeforeUpdater interface. | ||
| func (s *ActionResult) BeforeUpdate() error { | ||
| s.UpdatedAt = Now() | ||
| return nil | ||
| } | ||
|
|
||
| // AfterFind implements reform.AfterFinder interface. | ||
| func (s *ActionResult) AfterFind() error { | ||
| s.CreatedAt = s.CreatedAt.UTC() | ||
| s.UpdatedAt = s.UpdatedAt.UTC() | ||
| return nil | ||
| } | ||
|
|
||
| // check interfaces | ||
| var ( | ||
| _ reform.BeforeInserter = (*ActionResult)(nil) | ||
| _ reform.BeforeUpdater = (*ActionResult)(nil) | ||
| _ reform.AfterFinder = (*ActionResult)(nil) | ||
| ) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error return value of
f.Closeis not checked (fromerrcheck)