This repository was archived by the owner on Jun 21, 2022. It is now read-only.
Conversation
This was referenced Sep 9, 2019
AlekSi
suggested changes
Sep 10, 2019
Contributor
AlekSi
left a comment
AlekSi
left a comment
There was a problem hiding this comment.
We should:
- return values in API;
- handle value in Inventory API: any negative value means 0;
- handle default value in Management API: 0 means 1GB, negative value means 0.
Gopkg.toml
Outdated
| name = "github.com/percona/pmm" | ||
| branch = "PMM-2.0" | ||
| #branch = "PMM-2.0" | ||
| branch = "PMM-4437-flush-slowlogs" |
This was referenced Sep 11, 2019
Codecov Report
@@ Coverage Diff @@
## PMM-2.0 #264 +/- ##
===========================================
- Coverage 43.9% 43.88% -0.02%
===========================================
Files 79 79
Lines 8168 8203 +35
===========================================
+ Hits 3586 3600 +14
- Misses 4303 4323 +20
- Partials 279 280 +1
Continue to review full report at Codecov.
|
# Conflicts: # Gopkg.lock # vendor/github.com/percona/pmm/api/agentpb/agent.pb.go
golangcibot
reviewed
Sep 12, 2019
| _, err = db.Exec( | ||
| "INSERT INTO agents (agent_id, agent_type, runs_on_node_id, disabled, status, created_at, updated_at, "+ | ||
| "tls, tls_skip_verify) VALUES ('/agent_id/1', 'pmm-agent', '/node_id/1', false, '', $1, $2, false, false)", | ||
| "INSERT INTO agents (agent_id, agent_type, runs_on_node_id, pmm_agent_id, disabled, status, created_at, updated_at, tls, tls_skip_verify, query_examples_disabled, max_query_log_size) "+ |
| _, err = db.Exec( | ||
| "INSERT INTO agents (agent_id, agent_type, runs_on_node_id, pmm_agent_id, disabled, status, created_at, updated_at, "+ | ||
| "tls, tls_skip_verify) VALUES ('/agent_id/2', 'pmm-agent', '/node_id/1', NULL, false, '', $1, $2, false, false)", | ||
| "INSERT INTO agents (agent_id, agent_type, runs_on_node_id, pmm_agent_id, disabled, status, created_at, updated_at, tls, tls_skip_verify, query_examples_disabled, max_query_log_size) "+ |
| _, err = db.Exec( | ||
| "INSERT INTO agents (agent_id, agent_type, runs_on_node_id, pmm_agent_id, disabled, status, created_at, updated_at, "+ | ||
| "tls, tls_skip_verify) VALUES ('/agent_id/3', 'mysqld_exporter', NULL, '/agent_id/1', false, '', $1, $2, false, false)", | ||
| "INSERT INTO agents (agent_id, agent_type, runs_on_node_id, pmm_agent_id, disabled, status, created_at, updated_at, tls, tls_skip_verify, query_examples_disabled, max_query_log_size) "+ |
BupycHuk
approved these changes
Sep 13, 2019
| 4: { | ||
| `ALTER TABLE agents | ||
| ADD COLUMN query_examples_disabled BOOLEAN NOT NULL DEFAULT FALSE, | ||
| ADD COLUMN max_query_log_size INTEGER NOT NULL DEFAULT 0`, |
Contributor
There was a problem hiding this comment.
looks like we might need extra table or json column for params based on agent_type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.percona.com/browse/PMM-4459
https://jira.percona.com/browse/PMM-4437
depends on:
percona/pmm-admin#59
#264
percona/qan-app#322
FB:
Percona-Lab/pmm-submodules#444
usage ex.:
pmm-admin add mysql --username=root --password=secret ps:3306 MySQLSlowLog --size-slow-logs=10MB